🐛 Optimize Relap widget loading
🐛 Fixes #38474
Also fixed widget examples
Hey @ampproject/wg-caching! These files were changed:
validator/testdata/feature_tests/ads.html
validator/testdata/feature_tests/ads.out
you might want to rebase this and push the code to the PR again cause it seems circle CI got stuck
Look like the validator error is real. Can you fix? @advzr
Fixed validation errors. Failing tests probably caused by the upstream code. I will wait for a new nightly build and rebase my code on it.
Adding @erwinmombay for bundle size approval. It only affects this specific vendor bundle so shouldn't be a big deal.
Ping. @erwinmombay will you approve bundle size and owners check?
Warning: disparity between this PR Percy build and its main build
The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.
This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:
- If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
- If the disparity appears to be a flake, please @-mention
ampproject/wg-approversin a comment - If there is no disparity and this comment was created by mistake, please @-mention
ampproject/wg-infra - If unsure, @-mention
ampproject/wg-approvers