amphtml icon indicating copy to clipboard operation
amphtml copied to clipboard

🐛 Optimize Relap widget loading

Open advzr opened this issue 3 years ago • 2 comments

🐛 Fixes #38474

Also fixed widget examples

advzr avatar Oct 05 '22 13:10 advzr

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 05 '22 14:10 CLAassistant

Hey @ampproject/wg-caching! These files were changed:

validator/testdata/feature_tests/ads.html
validator/testdata/feature_tests/ads.out

amp-owners-bot[bot] avatar Oct 05 '22 14:10 amp-owners-bot[bot]

you might want to rebase this and push the code to the PR again cause it seems circle CI got stuck

erwinmombay avatar Oct 31 '22 21:10 erwinmombay

Look like the validator error is real. Can you fix? @advzr

powerivq avatar Nov 02 '22 07:11 powerivq

Fixed validation errors. Failing tests probably caused by the upstream code. I will wait for a new nightly build and rebase my code on it.

advzr avatar Nov 03 '22 08:11 advzr

Adding @erwinmombay for bundle size approval. It only affects this specific vendor bundle so shouldn't be a big deal.

powerivq avatar Nov 04 '22 18:11 powerivq

Ping. @erwinmombay will you approve bundle size and owners check?

advzr avatar Nov 10 '22 09:11 advzr

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

  • If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
  • If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
  • If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
  • If unsure, @-mention ampproject/wg-approvers

ampprojectbot avatar Nov 14 '22 23:11 ampprojectbot