amphtml icon indicating copy to clipboard operation
amphtml copied to clipboard

🌸 Cherry-pick request for PR #38394 into 2207281718001 (current stable), 2208051912000 (beta/experimental)

Open erwinmombay opened this issue 3 years ago • 2 comments

Issue (Bug)

#38394

Pull Request(s)

#38394

AMP Version(s)

2207281718001, 2208051912000

Channels

Beta / Experimental, Stable, LTS

Formats

Stories

Justification

While manually testing the ssr-css experiment, extensions that were dependent on amp-story to load first and initialize its services, break on some occasions (when amp-story loads first it works, when the extension load first it breaks). This is because waitWhenReady for extensions breaks as it uses parseExtensionUrl to detect if an extension even exists on the page to wait on.

Verification Steps

Load an amp-story page with a poll/quiz such as https://wsdemos.uc.r.appspot.com/art-quiz and make sure the interactions work

Summary

N/A see Justification section. The issue does not exist in production as it is flag guarded. We just need to fix it so i can start the experiment.

Impact

No users were affected

Action Items

No response

Notifications

/cc @ampproject/release-on-duty @ampproject/wg-approvers @ampproject/cherry-pick-approvers

erwinmombay avatar Aug 10 '22 17:08 erwinmombay

🌸 Cherry-Pick Progress 🌸

Hi @erwinmombay, thanks for filing this cherry-pick request! Seeing that this affects Stable and LTS, status.amp.dev will be updated with progress of the fix. Please update this tracker as each step is completed.

  • [x] Cherry-pick request approved (this creates an incident on status.amp.dev)
  • [x] Cherry-pick started (this sets the incident status to "Identified")
  • [x] Fix deployed to release channels (this sets the incident status to "Monitoring")
  • [x] Fix verified on release channels (this resolves the incident)

ampprojectbot avatar Aug 10 '22 17:08 ampprojectbot

Approved

newmuis avatar Aug 10 '22 17:08 newmuis