amphtml icon indicating copy to clipboard operation
amphtml copied to clipboard

🐛 [amp-jwplayer] Allow video docking during ad playback

Open zetagame opened this issue 3 years ago • 8 comments

This PR reverts amp-jwplayer to dispatching VideoEvents_Enum.PLAYING and VideoEvents_Enum.PAUSE on adPlay and adPause to allow for video docking during ad playback. In addition, element now triggers VideoEvents_Enum.PLAY on first playback of a playlist item to prevent redispatch of VideoAnalyticsEvents_Enum.PLAY on subsequent plays of a playlist item.

zetagame avatar Mar 08 '22 20:03 zetagame

Note: There is a test failing on e2e but it is marked as flaky and shouldn't be affected by these changes.

zetagame avatar Mar 09 '22 16:03 zetagame

@alanorozco Hey, long time no talk! Any chance we could get some eyes/feedback on this?

zetagame avatar Apr 08 '22 16:04 zetagame

hi @rbeckthomas! Just following up to see if there were any updates regarding this PR? I see you're the only reviewer listed here and this ticket was passed onto me to track haha.

Dawolee avatar May 24 '22 17:05 Dawolee

@rbeckthomas just checking in one more time? Any chance you can review this or recommend who can? Thanks in advance!

Dawolee avatar Aug 18 '22 20:08 Dawolee

hi @alanorozco! By any chance would you be the right person to review this or would you know who can? Thank you :]

Dawolee avatar Aug 18 '22 20:08 Dawolee

Hey @Dawolee I have reassigned to @alanorozco who will be able to better direct this PR.

rbeckthomas avatar Aug 18 '22 22:08 rbeckthomas

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


zetagame seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 09 '23 14:03 CLAassistant

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 17 '24 13:03 stale[bot]