amphtml icon indicating copy to clipboard operation
amphtml copied to clipboard

Web Stories option to disable/hide share button

Open LuckynaSan opened this issue 4 years ago • 12 comments

Describe the new feature or change to an existing feature you'd like to see

A user of the Web Stories WordPress plugin requested to hide/remove the share button in the story player. Submitting this as a feature request since disabling sharing is not possible by default.

Additional context

See the following related issues in the Web Stories WordPress forum: https://wordpress.org/support/topic/how-do-i-remove-the-share-button/ https://wordpress.org/support/topic/how-do-i-hide-the-share-button/ https://wordpress.org/support/topic/twitter-linkedin-at-the-end-of-the-story/ https://wordpress.org/support/topic/how-can-i-add-custom-css-to-story-page/#post-14250792

LuckynaSan avatar Feb 24 '21 16:02 LuckynaSan

Hi @newmuis, if this is something the Stories WG is interested in adopting I'd be happy to look into it!

nickFalcone avatar Mar 10 '21 04:03 nickFalcone

+1 request: https://wordpress.org/support/topic/how-do-i-turn-off-the-sharing-function-in-the-upper-right-corner/

LuckynaSan avatar Aug 16 '21 20:08 LuckynaSan

Enabling embed modes in the player would allow for this, which is currently tracked as part of #26308.

newmuis avatar Aug 17 '21 20:08 newmuis

News? How can I hide this button?

ofmarconi avatar Dec 13 '21 05:12 ofmarconi

@ampproject/wg-stories if anyone's interested, this would likely be a small task (to make the amp-story-player support embedMode)

/cc @gmajoulet

newmuis avatar Dec 13 '21 20:12 newmuis

Publishers should be able to add the embedMode manually in the URL fragment, we keep these https://github.com/ampproject/amphtml/blob/5d6d649eea0fa479d36d3973131560ccebe4a775/src/amp-story-player/amp-story-player-impl.js#L1380-L1383

Adding #embedMode=2 to URLs should remove sharing altogether, e.g. https://publisher.com/story#embedMode=2

gmajoulet avatar Dec 13 '21 20:12 gmajoulet

SGTM as a workaround. We would, then, at least need documentation on the semantics of the embed modes.

newmuis avatar Dec 14 '21 21:12 newmuis

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 24 '22 03:12 stale[bot]

👋 Was wondering if there are any updates on this? and any ways to remove the share btn outside of amp-story-player?

pietrop avatar Feb 23 '23 15:02 pietrop

Removing the share button outside of amp-story-player is a non-goal and is not what is being tracked by this issue. If you wish to remove the share button, it must be done from within the player.

newmuis avatar Feb 23 '23 16:02 newmuis

How can I hide this button?

aledesousa avatar Jul 25 '24 05:07 aledesousa

@aledesousa please follow the fix posted in this comment: https://github.com/ampproject/amphtml/issues/32862#issuecomment-992867658

gmajoulet avatar Aug 19 '24 16:08 gmajoulet