amp-inline-gallery throws an error if used within an amp-list

[rickbairstow]

What's the issue?

When trying to use amp-inline-gallery and amp-base-carousel within an amp-list template, an error is thrown for getImpl is not a function. This invalidates amp and doesn't render the thumbs, however it does still render the main carousel.

I'm raising this as an issue as our current solution uses amp-carousel within an amp-list without invalidating or any other issues. I was trying to update our current solution as it uses a separate amp-list for the thumbs.

This is my first issue report with AMP so please let me know if I need to do anything further or if you need a better explanation. Thanks.

How do we reproduce the issue?

I've replicated a basic test case with vastly reduced data that will produce the error: https://codepen.io/RickRX/pen/YzyEdvw

What browsers are affected?

All.

Which AMP version is affected?

2004240001480

[candice-womp]

Is there any movement on this issue? We’re currently working on a project where we’re trying to nest an amp-inline-gallery in an amp-list, however we are seeing the same message in the console as the OP and as a result it’s invalidating the AMP.

[kevinkimball]

cc @ampproject/wg-components

[zhouyx]

@alanorozco I wonder if <amp-inline-gallery> is supported within <amp-list>? Is this more of a feature request or a bug. cc @dmanek as well since this is related to <amp-list>

[rickbairstow]

I've revisited this again today and to extend on my original post, it looks like it's specifically not building amp-inline-gallery-thumbnails when used in an amp-list.

I don't know enough about amp to know if it's an issue with amp-list not supporting <amp-inline-gallery, but considering that it correctly builds everything but the thumbs 🤷

Please let me know if I do need to put in a feature request, as the sooner there's a fix for this the better. Solving this would pretty much make amp-inline-gallery the ideal solution to our use case (ecommerce product page images and thumbnails).

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.