amphtml icon indicating copy to clipboard operation
amphtml copied to clipboard

🏗 Ban private properties in integration tests

Open jridgewell opened this issue 6 years ago • 3 comments

Re: https://github.com/ampproject/amphtml/issues/24124

jridgewell avatar Aug 21 '19 23:08 jridgewell

Is this ready to merge in?

mrjoro avatar Jun 11 '20 17:06 mrjoro

Looks like this PR doesn't address all of the use-case since some integration tests appear to run only when non-obfuscated.

For instance: https://github.com/ampproject/amphtml/blob/master/test/integration/test-video-players-helper.js#L65

kristoferbaxter avatar Jan 08 '21 19:01 kristoferbaxter

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 22 '22 09:07 CLAassistant