amp-vimeo: Add support for unlisted videos
Describe the new feature or change to an existing feature you'd like to see
Normal Vimeo URLs look like: https://vimeo.com/172355597
But Vimeo also has the ability to create unlisted videos: https://vimeo.com/blog/post/share-unlisted-videos-with-private-links/
Such unlisted video URLs look like: https://vimeo.com/172355597/abcdef0123
However, the amp-vimeo component has no way to supply the unlisted secret key. It only has a data-videoid attribute.
Additional context
This issue was discovered as part of the AMP plugin for WordPress: https://github.com/ampproject/amp-wp/pull/2986
/cc @alanorozco
Hey @westonruter , do we have a private video we can use for testing this? (or a premium vimeo account?)
I am not aware of one, unfortunately.
Would it be safe to assume that the embed iframe will expect the same format (.../id/key) or would the iframe expect the key to be passed on as a parameter? I can't seem to find any documentation about embedding private videos on the Vimeo side (and I can't do trial and error since I don't have a private video on hand)
I was also unable to find documentation on how to embed private videos.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
This should still be done. We just need an example unlisted Vimeo video to test.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.