amp.dev icon indicating copy to clipboard operation
amp.dev copied to clipboard

amp-autocomplete example page for email has confusing title

Open zhangsu opened this issue 4 years ago • 3 comments

🐛 Bug Report

Current behavior

The page at https://amp.dev/documentation/examples/components/amp-autocomplete-email/?format=email has a title of Example: <amp-autocomplete-email>, which is confusing because the actual name of the component is just <amp-autocomplete>. amp-autocomplete-email is also referenced a few times later in the page.

Please also provide:

  • Page link: https://amp.dev/documentation/examples/components/amp-autocomplete-email/?format=email

Expected behavior/code

The title of the page should be Example: <amp-autocomplete>, and there should be no references to amp-autocomplete-email but amp-autocomplete.

/to @caroqliu

zhangsu avatar Jul 19 '21 19:07 zhangsu

@CrystalOnScript @sebastianbenz Do either of you know how we can update the example name? I can't rename the target file amp-autocomplete-email.html because amp-autocomplete.html already exists, otherwise that would likely be the most straight forward solution. It looks like other examples in the email have a .email ending, i.e.: https://amp.dev/documentation/examples/components/amp-bind-macro.email/?format=email, however I'm not seeing any .email files in the repo.

caroqliu avatar Jul 20 '21 14:07 caroqliu

Email samples are auto generated. I'll take a look.

sebastianbenz avatar Jul 20 '21 15:07 sebastianbenz

Any update here Sebastian?

zhangsu avatar Nov 20 '21 21:11 zhangsu