amp.dev icon indicating copy to clipboard operation
amp.dev copied to clipboard
verified publisher icon ampproject

Subscription settings sample for email has validation errors and missing data-css-strict

Open zhangsu opened this issue 5 years ago • 3 comments

🐛 Bug Report

Current behavior

The "Subscription settings" sample for the email format currently has validation errors. Beside ones that can be trivially fixed, it uses a Mustache variable in the middle of an amp-img URL which is banned in the email spec. If Mustache variable is used, then it must be substituting the entire URL and not partially.

It's also missing the data-css-strict attribute on <html>, which is required to enable strict CSS validation for email. After it's enabled, there's 1 CSS validation failure caused by using cursor: progress.

Please also provide:

  • Page link: https://playground.amp.dev/?runtime=amp4email&url=https%3A%2F%2Fpreview.amp.dev%2Fdocumentation%2Fexamples%2Finteractivity-dynamic-content%2Fsubscription_settings

Expected behavior/code

No validation error

zhangsu avatar Feb 02 '21 01:02 zhangsu

@sebastianbenz any chance this can get prioritized soon?

zhangsu avatar Nov 20 '21 21:11 zhangsu

Thanks for the ping. @patrickkettner can you take a look?

sebastianbenz avatar Nov 23 '21 10:11 sebastianbenz

yes

patrickkettner avatar Nov 23 '21 17:11 patrickkettner