Remove PHPCS and replace with ECS
This PR removes PHPCS and replaces it with ECS - Easy Coding Standard.
This has the following advantages:
- Use of both PHPCS and PHPCSF via one PHP config file
- Advanced caching for quick rechecking during development
- Possibility to check code snippets in markdown files
Overall, ECS seems to offer advantages over PHPCS for this repo. It is only supported right now from PHP 7.1 onwards, though.
So, if we want to go forward with this, we'll have to do one of:
- manually remove the ECS dependency on PHP < 7.1
- download the ECS Phar on-demand for code style checks
- bump PHP minimum version from PHP 5.6 to PHP 7.1
Something to note: the original idea of trying to move to ECS is that it will allow the code generation for the validator spec to be run through the ECS fixed, which reliably enforces the exact same code style than for the rest of the code. This is unfortunately not easily done with PHPCS, as its fixing only covers a part of its ruleset.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.
:white_check_mark: westonruter
:white_check_mark: schlessera
:x: github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.