redis Missing commands

Hi guys,

Today it added amphp/redis to our project to replace the classic phpredis implementation. I noticed that a couple of commands are missing - e.g. zrangebyscore, zrevrangebyscore and others.

Those commands are quite simple to implement. Would you accept an MR? What are your requirements on tests etc?

Thanks :)

Sep 30 '22 17:09 brstgt

Hey Benjamin,

sure, we'll accept PRs for any missing commands. Tests would be great to ensure things work correctly. They're usually very simple to write as well. 🙂

Sep 30 '22 19:09 kelunik

Looks like we forgot to close this after merging these commands in #77. Tagged as v1.1.0.

Dec 31 '22 05:12 trowski

@trowski Seems like you didn't actually tag anything?

Dec 31 '22 14:12 kelunik

No, it seems I either forgot to push or the push failed. Since I didn't actually tag, should we review and make changes to #78, merge, then tag?

Dec 31 '22 15:12 trowski

Aaron Piotrowski @.***> schrieb am Sa. 31. Dez. 2022 um 16:07:

No, it seems I either forgot to push or the push failed. Since I didn't actually tag, should we review and make changes to #78 https://github.com/amphp/redis/pull/78, merge, then tag?

— Reply to this email directly, view it on GitHub https://github.com/amphp/redis/issues/76#issuecomment-1368239326, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRAZ4FXSCJPV3IVQLVCMLWQBD2RANCNFSM6AAAAAAQZ7CN5E . You are receiving this because you authored the thread.Message ID: @.***>

Dec 31 '22 18:12 brstgt