file icon indicating copy to clipboard operation
file copied to clipboard

Add path not exists exception which specifies the path

Open dantleech opened this issue 6 years ago • 2 comments

Specify the path which doesn't exist when the path doesn't exist.

I can't test this locally as I don't have the necessary extensions (eio, uv) to install the dev dependencies. I manually deleted the extension deps from composer.

Looks like you also need to update Travis - the legacy integrations have broken.. (you can migrate here )

dantleech avatar Apr 13 '20 10:04 dantleech

There doesn't seem to be any tests for path not exists - and I think it should be consistent across drivers, so could do:

  • Add tests for "not exists" to the driver test case and update all the other implementations
  • OR
  • Remove the custom exception and just add a factory method for the exception in ParallelDriver

dantleech avatar Apr 13 '20 10:04 dantleech

Shouldn't you update all drivers?

enumag avatar Apr 13 '20 16:04 enumag