s390x: avoid to set serial console

[alicefr]

The serial console and the sclpconsole conflict with this error on s390x: qemu-system-s390x: -device sclpconsole,chardev=console: Multiple VT220 operator consoles are not supported qemu-system-s390x: -device sclpconsole,chardev=console: SCLP event initialization failed.

We can only enable the sclpconsole console

Signed-off-by: Alice Frosi [email protected]

[marcosps]

LGTM. @amluto do you have a better idea to solve this issue?

[amluto]

I clearly don't understand what's going on here. Without this patch, we get this:

-device sclpconsole,chardev=console
-parallel none
-net none
-echr 1
-serial none
-chardev stdio,id=console,signal=off,mux=on
-serial chardev:console
-mon chardev=console

This does indeed fail, but removing -serial none doesn't help.

Want to make a new patch that wires this up in a somewhat sensible way through architectures.py and makes the correct change to the arguments? It looks like there should be a default function that supplies -serial chardev:console and an s390x override that supplies the -device sclpconsole,chardev=console.

[marcosps]

I tested the solution proposed in #75, and since it's more generic I believe that we can have it merged. What do you think?

[arighi]

This has been merged/fixed in https://github.com/arighi/virtme

NOTE: we are trying to catch up with all the pending PR in this temporary fork. In the future we may merge everything back here if this project become active again, but for now please consider to follow also the development of arighi/virtme.