RecordGenerator icon indicating copy to clipboard operation
RecordGenerator copied to clipboard
verified publisher icon amis92

Added optional parameter withing

Open bboyle1234 opened this issue 6 years ago • 1 comments

https://github.com/amis92/RecordGenerator/issues/102

bboyle1234 avatar Sep 20 '19 11:09 bboyle1234

I'm glad you built this so quickly and easily, working simple code is the best code.

However:

  • Any new Feature should be first hidden behind a new Features flag.
  • Attributes namespace/package isn't the best place for embedding Optional. Also embedding is the last solution I'd like to go with. Let's keep discussing this in #102.
  • Making the Optional parameters in doesn't really help performance, I think. It's a small struct.

amis92 avatar Sep 20 '19 12:09 amis92