bitrot icon indicating copy to clipboard operation
bitrot copied to clipboard

require python>=3.9

Open juanep97 opened this issue 2 years ago • 3 comments

The syntax in tests/test_bitrot.py

StdOut = list[str]
StdErr = list[str]

was implemented in 3.9 for the first time.

juanep97 avatar Aug 10 '23 20:08 juanep97

How about instead we just put those lines in a if TYPE_CHECKING: block?

ambv avatar Aug 24 '23 08:08 ambv

Then we can keep 3.8 compatibility.

ambv avatar Aug 24 '23 08:08 ambv

I agree. In addition:

  • Added in .gitignore some python compiling and distribution related files.
  • Fixed setuptools_scm usage in the .toml file.

Fixing setuptools_scm was necessary to avoid this error when installing with pip install -e .:

          return meta(
        File ".../site-packages/setuptools_scm/version.py", line 226, in meta
          parsed_version = _parse_tag(tag, preformatted, config)
        File ".../site-packages/setuptools_scm/version.py", line 203, in _parse_tag
          assert version is not None
      AssertionError
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build editable did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

juanep97 avatar Aug 31 '23 16:08 juanep97