amber icon indicating copy to clipboard operation
amber copied to clipboard

Inexistent docker image in generated Dockerfile

Open kidandcat opened this issue 2 years ago • 3 comments

Description

When using amber new app, the generated Dockerfile is requiring FROM amberframework/amber:1.4.1. But that image do not exist in the docker registry: https://hub.docker.com/r/amberframework/amber/tags

Steps to Reproduce

  1. amber new app
  2. docker compose up

Expected behavior: App start

Actual behavior: failed to solve: amberframework/amber:1.4.1: docker.io/amberframework/amber:1.4.1: not found

Reproduces how often: 100%

Versions

Amber CLI (amberframework.org) - v1.4.1

Crystal 1.10.1 (2023-10-13) LLVM: 15.0.7 Default target: x86_64-apple-macosx

MacOS Sonoma (M2) 14.1

Additional Information

Changing it to FROM amberframework/amber:latest works.

kidandcat avatar Oct 26 '23 11:10 kidandcat

Hey sorry I hit this just browsing around. I was also solving this , I just went back to this repo and switch to whatever version/tag I am using (now is that 1.4.1 you mentioned):

git checkout v1.4.1

And the Dockerfile is in root, so I just tag it the same way as the default generated app has it:

docker build -t amberframework/amber:1.4.1 .

NOTE: I don't use the migrate service from compose, I do it by hand with docker exec -it YOUR-AMBER-APP bash

hope it helps somebody ;)

redrick avatar Nov 19 '23 21:11 redrick

It would be good to create multi-platform images automatically and push them. Unfortunately, it requires hosting your own servers to build them which costs money.

drujensen avatar Nov 20 '23 17:11 drujensen

I might be missing something here, but I would think it's just setting up a Github Action to build and push the image?

https://github.com/reload/php-fpm/blob/main/.github/workflows/release.yml

xendk avatar Jun 06 '24 20:06 xendk