amazon-braket-sdk-python icon indicating copy to clipboard operation
amazon-braket-sdk-python copied to clipboard

Remove parametric calibration workaround

Open jcjaskula-aws opened this issue 1 year ago • 1 comments

Issue #, if available: When we started vending calibrations, we introduced a workaround to avoid providing parametric calibrations with quantum circuits. For example, the following circuit:

OPENQASM 3.0;
defcal rx(theta) $0 {
 ...
}
rx(0.2) $0;

would be modified to

OPENQASM 3.0;
defcal rx(0.2) $0 {
 ...
}
rx(0.2) $0;

Description of changes: The present PR intends to keep track of this workaround and provide the right behavior.

Testing done: Unit tests added. As the workaround has been implemented due to a limitation of the service, we should probably add integ tests as well.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ ] I have read the CONTRIBUTING doc
  • [ ] I used the commit message format described in CONTRIBUTING
  • [ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ ] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jcjaskula-aws avatar Mar 18 '24 17:03 jcjaskula-aws

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (661529a) to head (9ea4a07).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #915   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          132       132           
  Lines         8823      8803   -20     
  Branches      1986      1978    -8     
=========================================
- Hits          8823      8803   -20     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 18 '24 17:03 codecov[bot]