amazon-braket-sdk-python icon indicating copy to clipboard operation
amazon-braket-sdk-python copied to clipboard

Add in-place modifications of waveforms

Open jcjaskula-aws opened this issue 2 years ago • 1 comments

Issue #, if available: Circuits and PulseSequences with waveforms cannot be reliably modified.

Description of changes: We have implemented setters for every waveform parameters which update the Braket waveform and the OQPy waveform variables.

Testing done: Added a unit test.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ ] I have read the CONTRIBUTING doc
  • [ ] I used the commit message format described in CONTRIBUTING
  • [ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ ] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jcjaskula-aws avatar Oct 05 '23 16:10 jcjaskula-aws

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (07d9e1e) to head (295349e). Report is 130 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #726    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          134       134            
  Lines         8857      8968   +111     
  Branches      1989      2018    +29     
==========================================
+ Hits          8857      8968   +111     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 18 '24 22:03 codecov[bot]