SCM-Localization-Issues icon indicating copy to clipboard operation
SCM-Localization-Issues copied to clipboard

Crash With Optifine and Circuits inside Circuits

Open maginator opened this issue 9 years ago • 9 comments

Its Crash with Optifine and when i place a Circuit inside a Circuit Crash Report: crash-2016-11-06_16.45.53-client.txt

maginator avatar Nov 06 '16 15:11 maginator

It also Crash when i Covert a Circuit. Happend with Optifine 1.10.2 HD Ultra D1/D2

maginator avatar Nov 06 '16 15:11 maginator

Welp. That one is Optifine's fault and I don't think I'll be able to fix it. This is what happens when you completely override the rendering pipeline >_>

amadornes avatar Nov 06 '16 16:11 amadornes

cross posted to optifine. https://github.com/sp614x/optifine/issues/314

Ristellise avatar Nov 07 '16 07:11 Ristellise

The "com.amadornes.rscircuits.client.SimpleModelFontRenderer" tries to use OpenGL functions on the chunk building thread and crashes because the thread has no OpenGL context. The chunk building threads does not have an OpenGL context and they can not use OpenGL functions, this limit comes from vanilla and OptiFine does not change it.

sp614x avatar Nov 07 '16 07:11 sp614x

This works fine on my client as well as on clients without Optifine, though, so there must be something going on. @RainWarrior has even made a PR to Forge where he includes it (that's where I got it) and it works perfectly.

amadornes avatar Nov 07 '16 21:11 amadornes

The GlStateManager is NOT thread-safe and it should only be called from the main thread. Otherwise it may break and all kind of random bugs can appear (broken textures, OpenGL errors, etc).

The SimpleModelFontRenderer cache can be populated on the main thread and then it can be used on any other thread as the values are cached and no OpenGL calls will be made.

sp614x avatar Nov 08 '16 07:11 sp614x

So, any plans to fix this yet as your not thread-safe code has been pointed out?

KitKat31337 avatar Dec 22 '16 04:12 KitKat31337

Still a problem. Anything we can do to help?

Baughn avatar Mar 09 '17 02:03 Baughn

Still a problem. Is this mod dead?

belathus avatar May 28 '17 03:05 belathus