alwex
database name as option, som small improvements
We need this for testing scripts that copy and create databases on the fly, so that we do not have to create environment files each time.
Hi Elgaard, thank you for contributing.
Can you please make sure that your code follow the PSR2 standard, I have updated the master branch fo comes with some dev utilities such as docker and phpcs to help contributors, a well as a guideline for contributors.
Please merge back master to your code and make sure:
- the code strictly follow PSR2 coding standards, you can run
bin/phpcs --standard=PSR2 Migrate/to verify. - any feature/option addition is covered by a unit test.
Thank you.
It now follows PSR2 and have unit tests. I added a check for the sqlite driver in the test script, because i spent some time on it before I realized that phpunit failed because of a missing driver.
I have commented on your code, but globally, it is about adding space around operators and removing extra blank lines, eg:
$dbname=$input->getOption('driver'); should be $dbname = $input->getOption('driver');
$currentDate = date('Y-m-d H:i:s',$time0); should be $currentDate = date('Y-m-d H:i:s', $time0);
which are formatting rules not covered by PSR2: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#7-conclusion