solarized icon indicating copy to clipboard operation
solarized copied to clipboard

Fix foreground color that has the same color as the background

Open ghost opened this issue 13 years ago • 13 comments

Replaced the light black with a gray instead of the dark blue which I believe is the same color as the background. This should solve #220, but I'm not 100% sure that I am using the right color.

Here's a screenshot of yeoman now:

Screen Shot 2013-01-21 at 7 59 14 PM

ghost avatar Jan 22 '13 01:01 ghost

@altercation @TrevorBramble bump. we've been waiting for a solution to #220 for half a year now...

sindresorhus avatar Mar 20 '13 17:03 sindresorhus

Unfortunately this fix breaks (at least) vim.

nocksock avatar Apr 05 '13 11:04 nocksock

That’s odd. It doesn’t seem to do that on my end.

ghost avatar Apr 05 '13 15:04 ghost

Yeah indeed, it seems to cause issues if you use vim (with the vim solarized dark colors) in iTerm2 (with my solarized fork).

I’m not sure then if the problem is with the iTerm2 or the vim theme. @TrevorBramble any ideas? Also, if you need any help dealing with all the PR maybe I can help a bit... not much activity in the repo lately.

ghost avatar Apr 29 '13 18:04 ghost

@noxoc I did a little tweak to the vim theme and at first glance it seems to do the trick. I’m no expert though. https://github.com/hydrozen/solarized/commit/13d13ea3ee5060c90baa650d6db7c2bd01dac33d

ghost avatar Apr 30 '13 03:04 ghost

bumping this thread in hope that this issue would be fixed

mente avatar Jul 08 '13 12:07 mente

ditto - hydrozen's fork fixes both iterm2 and vim for me (using item2 dark and solarized.vim)

maddie927 avatar Jul 11 '13 17:07 maddie927

@spicydonuts cool! glad someone is using this :)

ghost avatar Jul 11 '13 19:07 ghost

would be better if was merged. What's the stopper?

mente avatar Jul 11 '13 19:07 mente

I’m not sure, I’m not an expert in theme-making, but I feel like my forks are at the very least a step in the right direction in finding a solution.

ghost avatar Jul 12 '13 13:07 ghost

It can be used at least as workaround. @altercation @TrevorBramble guys, would be great if you merge it. Thanks :)

mente avatar Jul 12 '13 13:07 mente

I think we need to consider an official fork of this repo. The maintainer doesn't seem to care about fixing this issues. I don't blame him, this is a huge work.

antoinelyset avatar Feb 26 '14 09:02 antoinelyset

Anyone tried to increase iTerm2 's contrast ? Light gray color becomes visible after increasing contrast a little bit.

wenwuwu avatar Jun 16 '16 12:06 wenwuwu