alsa-tools icon indicating copy to clipboard operation
alsa-tools copied to clipboard

hdajackretask doesn't check for script's exit code

Open kroq-gar78 opened this issue 4 years ago • 1 comments

hdajackretask creates a script in /tmp before executing it. When /tmp is mounted with noexec, running that script will fail, but the GUI gives no indication that it failed.

I'm on Ubuntu 18.04.5, with alsa-tools-gui package version 1.1.3-1.

The GUI should check for the exit code of the script, and notify the user appropriately if the script failed to execute.

Also, if this isn't the appropriate place to report a bug, please let me know!

kroq-gar78 avatar Sep 06 '21 07:09 kroq-gar78

At hdajackretask/apply-changes.c:98, it looks like we get the exit code, but don't actually check it. Am I understanding this right?

kroq-gar78 avatar Sep 06 '21 07:09 kroq-gar78