sourcemod icon indicating copy to clipboard operation
sourcemod copied to clipboard

Add Support TLS in Webternet.

Open idk1703 opened this issue 3 years ago • 12 comments

Resolves #1497.

idk1703 avatar Nov 04 '22 11:11 idk1703

image I'm no alliedmodders developer, but I would consider paring down your merge request a bit...

sapphonie avatar Nov 04 '22 11:11 sapphonie

изображение Я не разработчик alliedmodders, но я бы подумал о том, чтобы немного сократить ваш запрос на слияние...

I think so too, but I see the full version of cURL in repo. Need delete all, except include, lib/library and license.

idk1703 avatar Nov 04 '22 11:11 idk1703

I think a git submodule would be appropriate.

rumblefrog avatar Nov 04 '22 21:11 rumblefrog

Thanks for working on this!

I'm no alliedmodders developer, but I would consider paring down your merge request a bit...

This is fine, the individual commits are suitably sized.

asherkin avatar Nov 04 '22 21:11 asherkin

I think this better, for keep clear repo.

idk1703 avatar Nov 05 '22 10:11 idk1703

how do we feel about introducing submodules for external dependencies?

I am in favour of this.

psychonic avatar Nov 25 '22 19:11 psychonic

Symlinks on windows require special capabilitities or SYSTEM privileges. So this breaks casual builds on windows :( @dvander knows AMBuild the best and probably knows how to integrate this best. Maybe we could get curl to look for the config files in other directories as well?

peace-maker avatar Dec 02 '22 12:12 peace-maker

symlink isn't the only problem. (1) third-party links in submodules are risky. They can and do disappear. They should be cloned into the alliedmodders organization. (2) modifying the source tree during the build is asking for trouble. instead, once the clone is available, these can be checked in as prebuilts, and updated on downstream merges.

dvander avatar Dec 02 '22 22:12 dvander

Need import or fork repos in AlliedModders.

curl, mbedtls

idk1703 avatar Dec 15 '22 16:12 idk1703

How create pr to new branch ? on curl and mbedtls repos. sm-ext <- sm-ext curl: sm-ext - new branch from tag curl-7_86_0 mbedtls: sm-ext - new branch from tag mbedtls-3.3.0

idk1703 avatar Dec 18 '22 12:12 idk1703

@idk1703 are you still blocked on this?

KyleSanderson avatar Mar 30 '23 05:03 KyleSanderson

So i think this done

curl - 7.86.0 mbedtls - 3.3.0

idk1703 avatar Nov 30 '23 18:11 idk1703