cli icon indicating copy to clipboard operation
cli copied to clipboard

Custom link for contribution categories

Open endel opened this issue 7 years ago • 7 comments

Hi there,

I'd like to propose a feature when generating links for "ideas" contribution. It would be handy to allow changing the link, without replacing the whole template.

Currently, the links for "ideas" are generated like this:

#ideas-{username}

I'd like to customize it to link to GitHub Issues. As this can vary from project to project, maybe all-contributors-cli could support link templates, per contribution category?

On "ideas" contributions we could have a couple of options, such as:

  1. Issues created by that user:
/{projectOwner}/{projectName}/issues/created_by/{username}
  1. Filtering issues with a specific label ("ideas" / "proposal" / etc)
/{projectOwner}/{projectName}/issues?q=author%3A{username}+label%3Aideas

What's your thoughts on this? Cheers!

endel avatar Mar 29 '18 16:03 endel

Hi @endel! Thanks for the suggestion!

What do you think of the suggestion here: https://github.com/jfmengels/all-contributors-cli/issues/47

The problem with your specific suggestion is that it's a little pigeon holed into a certain convention. Whereas the suggestion in #47 is a little more generic.

I personally don't have a lot of time to dedicate to this I'm afraid :-/

kentcdodds avatar Mar 29 '18 16:03 kentcdodds

@endel Would you like to submit a PR for this?

Berkmann18 avatar Jan 25 '19 14:01 Berkmann18

@endel Friendly ping.

Berkmann18 avatar Jun 11 '19 15:06 Berkmann18

Hey @Berkmann18, I don't have much time to contribute at this moment, unfortunately.

endel avatar Jun 11 '19 17:06 endel

@endel Did you get a chance to find time for this?

Berkmann18 avatar Mar 23 '21 11:03 Berkmann18

From a comment over in #47 :

Many contributions don't involve GitHub issues, so I don't think this makes sense as the default behavior. The problem with going with this solution is that we will still be in a situation where the default behavior for many projects creates a bunch of links that don't take you anywhere (in this case, empty filtered issue lists).

I'm skeptical that there's any default link behavior that could make sense given the variety of ways that people can contribute to a project. And the problem with generating useless links is that it has the effect of hiding the links that are actually useful.

i.e.; as a reader of a contributors list, you might be exploring and click 3 names that take you to an empty issues list. You (rightly) assume all of the contributors links are useless, so you stop clicking names. However, it's easy to imagine that a couple of people on the list have custom links set up that are meaningful...you just didn't happen to click those names.

jamesplease avatar Sep 15 '22 14:09 jamesplease

@jamesplease First of all. We thank you for sharing your thoughts with us. Let me share mine too.

https://github.com/all-contributors/cli/issues/47 suggested the manual way of doing it (unless there's a new idea being brought up aside from doing a lot of work) and on the other hand, https://github.com/all-contributors/cli/issues/88 suggested the automated way which in theory that we can use GH API to filter related issues before setting a valid link.

Also, I think not everyone is willing to do much work for setting each custom link/s for each contributor.

Any other suggestions and PR are very much welcome.

tenshiAMD avatar Sep 15 '22 17:09 tenshiAMD