Alexander Reynolds

icon indicating an email [email protected]

icon company nominal.io icon location New York, NY icon location Robots, distributed systems, signals, cv, metaprogramming. Python, c++, go, rust.

Results 11 issues of Alexander Reynolds

Incorrect type annotation for `messages_to_table()`: marked to take an `Iterable[M]` but requires `len()`

7 comment

Iterables can be infinite/don't necessary have a length, so [this line of code](https://github.com/tradewelltech/protarrow/blob/19e156346bda76bb3c214481217e88374e8f4c33/protarrow/proto_to_arrow.py#L530) invalidates the annotation. Length requires `Sized`. Could also use `Collection[M]` or `Sequence[M]` though those are a tad...