alibuild icon indicating copy to clipboard operation
alibuild copied to clipboard

Improve disable by architecture

Open ktf opened this issue 3 years ago • 4 comments

ktf avatar May 13 '22 11:05 ktf

Codecov Report

Merging #760 (52b7718) into master (35bf9aa) will increase coverage by 0.01%. The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
+ Coverage   87.17%   87.18%   +0.01%     
==========================================
  Files          29       29              
  Lines        2970     2982      +12     
==========================================
+ Hits         2589     2600      +11     
- Misses        381      382       +1     
Impacted Files Coverage Δ
alibuild_helpers/utilities.py 88.88% <62.50%> (-0.71%) :arrow_down:
tests/test_workarea.py 95.65% <0.00%> (-0.07%) :arrow_down:
tests/test_args.py 98.18% <0.00%> (ø)
tests/test_build.py 95.70% <0.00%> (ø)
alibuild_helpers/args.py 98.36% <0.00%> (+0.02%) :arrow_up:
alibuild_helpers/build.py 80.15% <0.00%> (+0.34%) :arrow_up:
alibuild_helpers/workarea.py 90.38% <0.00%> (+0.80%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov-commenter avatar May 13 '22 11:05 codecov-commenter

@davidrohr @martenole @awegrzyn: this should allow us to say that we do not want to bother about OpenSSL on anything but slc7. Either by stating:

architeture: slc7

which will simply disable the package on anything which is not slc7, or by saying:

system_requirement: slc7

which will consider the prefer_system_check (or alternatively system_requirement_check) as mandatory for the build to continue.

@awegrzyn could you please have a look? In principle this allows us to drop the system-XYZ packages as well, but IIRC you depend on those to create the RPMs. Is that actually the case?

ktf avatar May 13 '22 11:05 ktf

@TimoWilken could you cross check this makes sense?

ktf avatar May 13 '22 11:05 ktf

@ktf : thx, I think this makes a lot of sense (haven't tested it myself though).

davidrohr avatar May 15 '22 18:05 davidrohr