alist icon indicating copy to clipboard operation
alist copied to clipboard

[Recommend] Do not delete BT tasks automatically after the offline download is complete!

Open m0ch3 opened this issue 3 years ago • 1 comments

Please make sure of the following things

  • [x] I have read the documentation.
  • [X] I'm sure there are no duplicate issues or discussions.
  • [X] I'm sure this feature is not implemented.
  • [X] I'm sure it's a reasonable and popular requirement.

Description of the feature / 需求描述

Recommended that DO NOT make it the default behavior to automatically delete BT tasks after the offline download is complete, that's blood-sucking.

Suggested solution / 实现思路

An optional configuration or a button could be added to allow users to decide whether to automatically delete.

Additional context / 附件

Source code in v3.12.0 internal\qbittorrent\monitor.go from line 115 - 120:

// delete qbittorrent task but do not delete the files before transferring to avoid qbittorrent
// accessing downloaded files and throw `cannot access the file because it is being used by another process` error
err = qbclient.Delete(m.tsk.ID, false)
if err != nil {
    return err
}

After the qBittorrent download task is completed, no exclusive lock will be added to the file, but a read shared lock. Seems that it does not affect the the file reading, such as in Python: open("filePath","rb"), or in Golang: os.OpenFile(filePath, os.O_WRONLY|os.O_RDONLY, 0).

m0ch3 avatar Feb 24 '23 06:02 m0ch3

Thanks for opening your first issue here! Be sure to follow the issue template!

welcome[bot] avatar Feb 24 '23 06:02 welcome[bot]