Refactor SongCollection m_filtered and m_songs in songs.cc and add a copy SongCollection in requesthandler.cc

Open HetorusNL opened this issue 2 years ago • 1 comments

Suggestion

This suggestion is about how the current m_songs and m_filtered SongCollections are implemented in song.cc. Remove either m_filtered or m_songs, so having only a single SongCollection in songs.cc. Add a duplicate SongCollection to requesthandler.cc to separate the sorting/filtering in the web server from the filtering in songs.cc.

This removes the confusion around the two SongCollections in songs.cc. This would be the clean (refactored) implementation of PR #901 .

Use case

No response

Extra info/examples/attachments

No response

Aug 07 '23 17:08 HetorusNL

Linking #904 since they both reside in songs.cc might be good to pick up combined

Aug 07 '23 20:08 Baklap4