feat: sentinel can feel exception though application has configured E…
Describe what this PR does / why we need it sentinel can feel exception though application has configured ExceptionHandler
Does this pull request fix one issue? https://github.com/alibaba/Sentinel/issues/3141 https://github.com/alibaba/Sentinel/pull/3149
Describe how you did it Add a class SentinelExceptionAware which implement HandlerExceptionResolver and put exception into request.
Describe how to verify it UT & add it in my project
Special notes for reviews Thanks for your work.
@sczyh30 @jasonjoo2010 @brotherlu-xcq @LearningGp I have raised mr(https://github.com/alibaba/Sentinel/pull/3149) for a year so that sentinel default branch changed to 1.8. Maybe reviewer can be faster this time,thanks~
Codecov Report
Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.
Project coverage is 45.85%. Comparing base (
bb813dd) to head (5c2ba70). Report is 6 commits behind head on 1.8.
| Files | Patch % | Lines |
|---|---|---|
| ...ter/spring/webmvc/AbstractSentinelInterceptor.java | 0.00% | 15 Missing :warning: |
| .../adapter/spring/webmvc/SentinelExceptionAware.java | 0.00% | 7 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 1.8 #3409 +/- ##
============================================
- Coverage 45.90% 45.85% -0.06%
+ Complexity 2147 2146 -1
============================================
Files 431 432 +1
Lines 12906 12920 +14
Branches 1728 1731 +3
============================================
- Hits 5925 5924 -1
- Misses 6280 6294 +14
- Partials 701 702 +1
| Components | Coverage Δ | |
|---|---|---|
| sentinel-adapter | 43.00% <0.00%> (-0.23%) |
:arrow_down: |
| sentinel-cluster | 23.71% <ø> (ø) |
|
| sentinel-core | 59.62% <ø> (-0.02%) |
:arrow_down: |
| sentinel-extension | 46.19% <ø> (ø) |
|
| sentinel-logging | 54.54% <ø> (ø) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@sczyh30 @jasonjoo2010 @brotherlu-xcq @LearningGp I have raised mr(https://github.com/alibaba/Sentinel/pull/3149) for a year so that sentinel default branch changed to 1.8. Maybe reviewer can be faster this time,thanks~
@sczyh30 @jasonjoo2010 @brotherlu-xcq @LearningGp I have raised mr(https://github.com/alibaba/Sentinel/pull/3149) for a year so that sentinel default branch changed to 1.8. Maybe reviewer can be faster this time,thanks~
As a mature open source project, PR should be handled in a timely manner, rather than being shelved year after year. I am not sure whether this project is still maintained, or only people within Alibaba can get the review. Open source is not just for KPI, at least there should be enthusiasm, right?
As a mature open source project, PR should be handled in a timely manner, rather than being shelved year after year. I am not sure whether this project is still maintained, or only people within Alibaba can get the review. Open source is not just for KPI, at least there should be enthusiasm, right?
I'm sorry, this was indeed my oversight. The review for this PR has already been completed in the related PR, and it can be merged directly.
Apologize for my recklessness. I still like sentinel ~