Sentinel icon indicating copy to clipboard operation
Sentinel copied to clipboard

feat:sentinel can feel exception though application has configured ExceptionHandler

Open 24kpure opened this issue 2 years ago • 18 comments

Describe what this PR does / why we need it

sentinel can feel exception though application has configured ExceptionHandler

Does this pull request fix one issue?

#3141

Describe how you did it

Add a class SentinelExceptionAware which implement HandlerExceptionResolver and put exception into request.

Describe how to verify it

UT & add it in my project

Special notes for reviews

Thanks for your work.

24kpure avatar Jun 13 '23 02:06 24kpure

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 13 '23 02:06 CLAassistant

Contributor License Agreement was signed yet,but status is still pending. image

24kpure avatar Jun 14 '23 11:06 24kpure

Contributor License Agreement was signed yet,but status is still pending. image

That's because the email of your commits does not match the email of your GitHub account. You may need to readjust your commit with your GitHub-associated email.

sczyh30 avatar Jun 14 '23 15:06 sczyh30

Contributor License Agreement was signed yet,but status is still pending. image

That's because the email of your commits does not match the email of your GitHub account. You may need to readjust your commit with your GitHub-associated email.

Thanks for your reply.Everythins is ok,beside review.Cloud you review the code?

24kpure avatar Jun 18 '23 11:06 24kpure

@sczyh30 Cloud you review the code?Thandks.

24kpure avatar Jun 25 '23 07:06 24kpure

@sczyh30 Have a look,please.

24kpure avatar Jul 01 '23 09:07 24kpure

@sczyh30 Code has been changed,Thanks for your review ~ btw, is your profile picture murongziying in the legend of sword and fairy 4?

24kpure avatar Jul 07 '23 15:07 24kpure

@sczyh30 help!

24kpure avatar Jul 10 '23 13:07 24kpure

How time flies! @sczyh30 go on please ~

24kpure avatar Jul 28 '23 09:07 24kpure

@sczyh30 @jasonjoo2010 @brotherlu-xcq @LearningGp help~

24kpure avatar Aug 10 '23 05:08 24kpure

@sczyh30 @jasonjoo2010 @brotherlu-xcq @LearningGp help~

24kpure avatar Aug 22 '23 09:08 24kpure

@sczyh30 @jasonjoo2010 @brotherlu-xcq @LearningGp help~

24kpure avatar Oct 12 '23 02:10 24kpure

cc @LearningGp

sczyh30 avatar Oct 12 '23 02:10 sczyh30

cc ,please @LearningGp

24kpure avatar Oct 16 '23 08:10 24kpure

What ‘s’ the average processing time for pr?

24kpure avatar Oct 19 '23 10:10 24kpure

@LearningGp cc

24kpure avatar Nov 22 '23 05:11 24kpure

@sczyh30 @jasonjoo2010 @brotherlu-xcq @LearningGp help~

24kpure avatar Nov 29 '23 03:11 24kpure

@panxiaojun233 @jasonjoo2010 @brotherlu-xcq @LearningGp Have a look,please.

24kpure avatar Feb 29 '24 02:02 24kpure

Shall I change traget branch to 1.8?

24kpure avatar May 21 '24 11:05 24kpure

Shall I change traget branch to 1.8?

I'm sorry to have shelved this PR for so long, please change the target branch to 1.8 if it is convenient.

LearningGp avatar May 21 '24 12:05 LearningGp