Sentinel icon indicating copy to clipboard operation
Sentinel copied to clipboard

Fix the sysrule

Open huangyiminghappy opened this issue 3 years ago • 3 comments

Describe what this PR does / why we need it

All rules, including flowrule,degradeRule rules and even AbstractRule, are constructed using builder pattern to set attributes,In order to unify the use of rules and code style, we should set the SystemRule

Does this pull request fix one issue?

Describe how you did it

builder pattern to set attributes in SystemRule

Describe how to verify it

set attribute

Special notes for reviews

huangyiminghappy avatar Sep 26 '22 04:09 huangyiminghappy

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: nullhuangyiming
:x: huangyiminghappy


nullhuangyiming seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 26 '22 04:09 CLAassistant

Hi, thanks for contributing. This may lead to breaking changes (of API) and we might have to be careful of backward compatibility.

sczyh30 avatar Sep 26 '22 11:09 sczyh30

thank you reply,we just add builder pattern in set method,and return it self replace no return , Theoretically it can not lead to breaking changes (of API)

huangyiminghappy avatar Sep 27 '22 02:09 huangyiminghappy