Sentinel icon indicating copy to clipboard operation
Sentinel copied to clipboard

fix [ #1428] Support ZuulBlockFallbackProvider to return information custom

Open liuweiGit opened this issue 5 years ago • 2 comments

Describe what this PR does / why we need it

Does this pull request fix one issue?

fix 1428

Describe how you did it

Response.ok().put("");

Describe how to verify it

Special notes for reviews

liuweiGit avatar May 27 '20 04:05 liuweiGit

Codecov Report

Attention: Patch coverage is 64.40678% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 44.05%. Comparing base (ff0e53f) to head (73a7e3b). Report is 230 commits behind head on master.

:exclamation: Current head 73a7e3b differs from pull request most recent head be0322d. Consider uploading reports for the commit be0322d to get more accurate results

Files Patch % Lines
.../adapter/gateway/zuul2/fallback/BlockResponse.java 52.38% 10 Missing :warning:
...l/adapter/gateway/zuul/fallback/BlockResponse.java 66.66% 7 Missing :warning:
...er/gateway/zuul/filters/SentinelZuulPreFilter.java 0.00% 3 Missing :warning:
...ateway/zuul/fallback/ZuulBlockFallbackManager.java 85.71% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1508      +/-   ##
============================================
- Coverage     44.58%   44.05%   -0.54%     
+ Complexity     1804     1733      -71     
============================================
  Files           382      376       -6     
  Lines         10912    10690     -222     
  Branches       1467     1423      -44     
============================================
- Hits           4865     4709     -156     
+ Misses         5451     5412      -39     
+ Partials        596      569      -27     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 27 '20 04:05 codecov-commenter

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 6 committers have signed the CLA.

:white_check_mark: sczyh30
:white_check_mark: liuweiGit
:x: 刘伟
:x: joooohnli
:x: linlinisme
:x: zhenxianyimeng


刘伟 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 12 '20 07:06 CLAassistant