feat(interactive): Refactor and fix some bugs for `AdminService`
In this PR, we refactor some of the Interactive AdminService and fix some bugs.
- Limit the maximum number of bulk loading jobs via
bulk_loading_job_count_. - Let all
AdminActorAPIs returnseastar::future<gs::Result<seastar::sstring>>, with a mapping betweengs::StatusCodeand http status code, we can remove a lot of dummy code handling exception/unexpected behaviors. - Update the unit test for admin service.
- Refine the returned HTTP code, previously we returns a generic 500 error regardless of the specific error encountered.
Fix #3515
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 27.76%. Comparing base (
d46a354) to head (64eb44d). Report is 3 commits behind head on main.
:exclamation: Current head 64eb44d differs from pull request most recent head 5a02274. Consider uploading reports for the commit 5a02274 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #3406 +/- ##
=======================================
Coverage 27.76% 27.76%
=======================================
Files 178 178
Lines 16245 16245
=======================================
Hits 4511 4511
Misses 11734 11734
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 3c4bb8e...5a02274. Read the comment docs.
This PR has been divided into several small, merged PRs into main.