Format of crop_size

Open dfrumkin opened this issue 3 years ago • 1 comments

Is crop_size in the [height, width] format or [width, height]?

Here it's [height, width]: https://github.com/alibaba/ClickSEG/blob/main/models/strongbaseline/mobilenetv2_x1_comb.py#L41

However, https://github.com/alibaba/ClickSEG/blob/d61a76b2c88c56106e97d505ce41d16aa2535021/isegm/data/aligned_augmentation.py#L50 uses opencv's convention of [width, height]

Practically, this does not matter because it's a square, but then you could have used just one parameter instead of two.

Jun 22 '22 13:06 dfrumkin

Thank you. Maybe it is a mistake, I haven't noticed that because I always use square.

Jun 23 '22 03:06 XavierCHEN34