alexmdodge
Enhancement: Add support for GitHub enterprise
The Plugin currently only works with github.com but it would be nice if it also worked with a custom GitHub enterprise instance.
Definitely would be possible. I'd have to get my hands on the trial subscription to see what the DOM structure looks like. If they maintain parity between their UI then it would just be the work required to allow people to authorize their particular domain. When I get some time I'll look into what it would be like to get it working.
@tomquist A little bit delayed but I've been making some upgrades lately and have had some thoughts around the best way to accomplish this.
There are generally a complications around adding broad permissions, and to support enterprise, they would have to be extremely broad to account for all potential hosting options. Instead I'm wondering if adding a generate approach where you can more easily build the extension locally and provide the custom URL of your enterprise instance would work better.
For instance I could provide something like the following:
npx github-diff-exporer generate --enterprise --host=custom.github.com
Assuming that all internal paths remain the same for any hosted instance, then that could be loaded locally and should work out of the box.
@alexmdodge Would definitely be a solution, however not that convenient. The "Better Pull Requests for GitHub" extension works for GitHub enterprise too. I'm not an expert in chrome extensions but I think you could declare optional_permissions like they do and provide a button to request permission for accessing the page.