lirc_node icon indicating copy to clipboard operation
lirc_node copied to clipboard

Bugfix: call callback after fetching remote commands

Open OvisMaximus opened this issue 9 years ago • 1 comments

The init callback has been called directly after fetching the lirc remotes. The commands of these were not available then. Fixed by collecting the execs fetching the remote commands.

Since the involved methods solely rely on output of the executed commands, i see no reasonable way to implement a test which validates the timing.

OvisMaximus avatar Jan 30 '16 10:01 OvisMaximus

BTW, I had three tests not working, but I have not interferred with the code they depend on:

  1) IRReceive [child process listening for input] upon receiving input should execute the callback(s) each time the input is received, if no throttle was set:
     Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.


  2) IRReceive [child process listening for input] upon receiving input should execute the callback(s) just once while the key is held down, if throttle was set to 0:
     Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.


  3) IRReceive [child process listening for input] upon receiving input should execute the callback(s) once every Xms while the key is held down, if throttle was set to a positive integer:
     Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.

OvisMaximus avatar Jan 30 '16 10:01 OvisMaximus