Alex

Results 27 comments of Alex

This would be a useful action to have so you can build release binaries for use with web serial flashing. Would be handy to have an option to merge in...

If things are being enhanced it would be nice if `validateAttribute` could return a `promise` so you can have a complete callback. e.g ```js $('#my-form').yiiActiveForm('validateAttribute', 'attribute').done(validated => { }); ```

How would this work if you have a custom `ActiveQuery` that uses `addSelect`? ```php class TestAR extends ActiveRecord { public static function find() { return new TestQuery(get_called_class()); } } class...

```php $query = TestAR::find(); if ($myCondition) { $query->select('foo') } $query->test()->all(); ``` If the behavior does change I just think it needs to be well noted. To me with the above...

This could produce an unexpected result too. ```php $query = (new Query); $cols = ['col1', 'col2']; foreach ($cols as $col) { $query->addSelect($col); } ``` I'd be expecting ```sql SELECT `col1`,...

Is ```php $this->filter instanceof \Closure ``` still needed with `is_callable`? Could this be simplified to ```php if (is_callable($this->filter)) { ```

If you're able to use PHP7.1+ there's https://www.php.net/manual/en/closure.fromcallable.php e.g. ```php class foo { public static function bar() { return 'foo-bar'; } } $closure = Closure::fromCallable(['foo', 'bar']); echo call_user_func($closure); ``` Should...