alessandromaggio
feature request: add a integer lost packets number to the ResponseList object
Is your feature request related to a problem? Please describe. problem: currently ResponseList contains packets_lost variable which contains float ratio of lost packets to all sent packets. but we can not know how many exactly packets was lost.
Describe the solution you'd like we may add an other variable to ResponseList object for this and patch "append" method to count the lost packets
Describe alternatives you've considered we may use math operations to determine lost packets number from the existing data. for example, if count was 10, and packets_lost is 0.3, we know that 3 packets was lost. but float operations are not precise.
Hello, and sorry for late reply. Your suggestion is valid, but I think we should implement it in a different way now that we are at it. We should use the following variables.
-
self.stats_packets_sent= Total packets sent -
self.stats_packets_returned= Total packet sent for which we have received a reply -
self.stats_packets_lost= stats_packet_sent - stats_packets_returned (computed) -
self.stats_success_ratio= stats_packet_returned / stats_packets_sent (computed) -
self.stats_lost_ratio= 1 - stats_success_ratio (computed)
We can then keep the current name self.packets_lost as a computed property that maps to stats_lost_ratio for backward compatibility. If you edit your PR with those changes we can merge it and implement it in the next minor release.
Thank you for the code, changes are finem but can you please write tests for them?
Implemented in Release 1.1.3, out now! Thanks for providing the code for this!