pythonping icon indicating copy to clipboard operation
pythonping copied to clipboard

Ignore lost packets in the calculation of statistics

Open handymenny opened this issue 4 years ago • 1 comments

I've added some tests here: https://github.com/HandyMenny/pythonping/commit/a2ecdf2fbef8ffe684871d387c0c987ed9c93010 Besides the fact that they're too messy, without #66 they will fail

If you don't completely agree with these changes you might as well make it optional, but I think 99% of users don't want TIMEOUT to be considered in the stats. You might think of a special value when there is 100% packet loss, but in my opinion 0 is fine

handymenny avatar Apr 18 '21 22:04 handymenny

That is a good point, however it alters the behaviour of the application. We should make this way of computing stats optional if a flag is provided, and in a later breaking version switch it to the default approach. If @HandyMenny you could add that to your change we could integrate it in the next release. Thanks!

alessandromaggio avatar Jun 03 '21 06:06 alessandromaggio