Alex Schoenhofen comments

Results 15 comments of


                                            Alex Schoenhofen

typing(embeds): Retype embed methods to accept str instead of any

Has decent testing been done on all modified functions and things that call them? I wouldn't be surprised if NC internally relies on `str()` being used.

typing(embeds): Retype embed methods to accept str instead of any

I'm unsure if anything calls them internally, just wanted to check if you looked into that already or not. Also, the PR summary probably should get updated? I'm not seeing...

typing(embeds): Retype embed methods to accept str instead of any

Alright, so I did find one *slight* issue. `/examples/custom_interaction.py` calls `embed.set_author()`, but gives the `icon_url` kwarg an `Asset` object, rather than a string. `Asset` just returns `self._url` when `str()`'d, but...

feat(utils): add `integration_type` to `oauth_url` helper

If `integration_type` isn't specified or is set to `None`, it probably shouldn't be added to the URL.

feat(audit_logs): add `application_command_permission_update`

@spifory is this tested and confirmed to work?