Aleix Pol

Results 91 comments of Aleix Pol

Can you please provide a Pull Request?

It would make sense to come up with a test plan for this. The code looks okay and it's clearly needed, a clear plan to evaluate that this works better...

> (I hope I can find some time to review/work on this again soon...) Does this mean that this work in progress?

Can you maybe provide a Pull Request? An alternative would be to (not tested): ``` - m_cookie[i] = QLatin1Char(digits[dis(gen)]); + m_cookie.append(QLatin1Char(digits[dis(gen)])); ``` This way it would be easier to review.

Can you please try again after the last fixes?

> @aleixpol Do you know which fix resolved this issue? It should, at least in some cases. Note that what we see here is not causes, just symptoms.

If you want an issue to be addressed specifically, please create a separate ticket with logs explaining what you see. In general, knowing the processor and graphics card is not...

At the very least we'd need to merge this first: https://github.com/sddm/sddm/pull/1460 And I've been trying to stress test it but I'd appreciate it if the rest of you also did...

> I went ahead and bisected this and it looks like it broke in commit d46ad35. Based on what that commit does I assume the issue is that the greeter...

I think we are ready for a release, @plfiorini what do you think?