matrix-factorization-in-python icon indicating copy to clipboard operation
matrix-factorization-in-python copied to clipboard
verified publisher icon albertauyeung

Update: add gpu option

Open gionanide opened this issue 6 years ago • 3 comments

gionanide avatar Apr 17 '19 07:04 gionanide

Hi @gionanide , thank you for this contribution! I left a few comments in the code. Also, do you have any benchmark showing how using GPU can speed up the training process? It would be good to see some numbers in the readme file!

albertauyeung avatar Apr 19 '19 06:04 albertauyeung

Hello Albert @albertauyeung Because the matrix R in very small, the running time with and without GPU is the same, to see the difference you need to have bigger matrices. I can add in the read me file as comment the dimensions of a bigger array and the running times to illustrate the difference if you want.

gionanide avatar Apr 19 '19 07:04 gionanide

Looks good. Thanks! I will test and then merge soon.

albertauyeung avatar Apr 21 '19 02:04 albertauyeung