component-library-starter icon indicating copy to clipboard operation
component-library-starter copied to clipboard

configureFonts incorrectly written?

Open milonti opened this issue 7 years ago • 1 comments

Hello.

I was using this as a part of a project I'm working on, and specifically looking around configureFonts.js It doesn't seem like you have this file set up correctly. FontFaceObserver is made to take a string for the family, not an array of strings. This as far as I can tell causes all loads to fail when written in this manner.

Shouldn't it be an array of FontFaceObservers that get passed to a mapping function? One observer per font.

milonti avatar May 31 '18 16:05 milonti

Also, there's no @font-face rule anywhere in your CSS, so the font load is entirely useless and always fails, even if it was set up correctly.

milonti avatar May 31 '18 22:05 milonti