zilla icon indicating copy to clipboard operation
zilla copied to clipboard

Change deferred default to -1 and revert defense against deferred == -1

Open bmaidics opened this issue 2 years ago • 0 comments

In KafkaCacheClientProduceFactory:

                                if ((flags & FLAGS_FIN) == 0x00 && deferred == 0)
                                {
                                    error = ERROR_CORRUPT_MESSAGE;
                                    break init;
                                }

we had this code which resets stream in cases where we forget to set the deferred value in case of fragmented messages was removed to support not sending FIN bit and not having any more payload to send. The correct fix should be setting the deferred default value to -1 and check for that, but that requires a lot of changes in the kafka scenarios.

bmaidics avatar Feb 01 '24 17:02 bmaidics