bufferline.nvim icon indicating copy to clipboard operation
bufferline.nvim copied to clipboard

feat(duplicates): only treat as duplicate if in the same group

Open rickyelopez opened this issue 2 years ago • 2 comments

rickyelopez avatar May 08 '23 17:05 rickyelopez

@akinsho could it be this simple? Do any tests need to be updated?

rickyelopez avatar May 08 '23 17:05 rickyelopez

From my local testing it appears to work. Totally fair about adding an option and adding tests, will look into that. Thanks!

rickyelopez avatar May 08 '23 19:05 rickyelopez

@akinsho I know it's been nearly a year (😅) but I finally got around to this. Does this look good? First time I've worked with this test framework, any other tests you'd like to see?

rickyelopez avatar Feb 20 '24 22:02 rickyelopez

@akinsho any thoughts here?

rickyelopez avatar Mar 05 '24 23:03 rickyelopez

@rickyelopez implementation looks good. I just haven't had a lot of time to spend on open source recently. I was thinking also about if I could find a more concise name for the option as it's quite a mouthful at the moment but didn't really find anything

akinsho avatar Mar 06 '24 09:03 akinsho

No worries! Doesn't seem like anybody else has requested this, and it's working for me this way, so I'm find to leave it in a PR until you get back to this project

find a more concise name for the option as it's quite a mouthful at the moment but didn't really find anything

Heh, same. Happy to change it if you think of anything, but I came up empty

rickyelopez avatar Mar 06 '24 18:03 rickyelopez

Gave up on finding a new name 😆 don't think there's anything more concise that would actually explain the option

akinsho avatar Mar 07 '24 09:03 akinsho