WIP: autorun with delay

Open pianohacker opened this issue 7 years ago • 2 comments

Dec 21 '18 02:12 pianohacker

:heart: Thanks a lot for the PR! I will try to find some time to test and review it, though I could not manage to do that yet.

Dec 26 '18 18:12 akavel

I just compiled and run it for a test drive. I think this is pure awesome!!! :smile: I'm totally for adding this feature. Let's go with a regular review.

Apart from the comments I already added, one thing I'm somewhat worried about is a possible race between the autoRun "interrupt" and a "real" key pressed by user. Such that we Poll and start processing a real key, but before we managed to Stop the timer, it's already fired and enqueued a new "interrupt". It's not 100% clear to me if and how this can be avoided; but I am starting to have some initial intuition that it might be possible. Though it might require backing off from the "NewEventKey(KeyEnter,...)" hack. edit: Or maybe not? There could be some counter of KeyEnters to ignore... ehh, anyway, currently I think this "avoidance" will be a tad bit ugly anyway.

Jan 03 '19 21:01 akavel