node
node copied to clipboard
Validation of manifests is wrong around hostname requirements
I got this check wrong https://github.com/ovrclk/akash/blob/master/provider/service.go#L83
It should be
HTTPServicesRequireAtLeastOneHost: !cfg.DeploymentIngressStaticHosts,
Also while looking into this I realized we have this code that makes sense:
https://github.com/ovrclk/akash/blob/master/provider/cluster/kube/settings.go#L40
But we don't call it anywhere.
First part has been fixed, the other validation code needs to be called somewhere