node icon indicating copy to clipboard operation
node copied to clipboard

Validation of manifests is wrong around hostname requirements

Open hydrogen18 opened this issue 5 years ago • 1 comments

I got this check wrong https://github.com/ovrclk/akash/blob/master/provider/service.go#L83

It should be

HTTPServicesRequireAtLeastOneHost: !cfg.DeploymentIngressStaticHosts,

Also while looking into this I realized we have this code that makes sense:

https://github.com/ovrclk/akash/blob/master/provider/cluster/kube/settings.go#L40

But we don't call it anywhere.

hydrogen18 avatar Jan 13 '21 20:01 hydrogen18

First part has been fixed, the other validation code needs to be called somewhere

hydrogen18 avatar Jan 28 '21 00:01 hydrogen18