NetStorageKit-Node icon indicating copy to clipboard operation
NetStorageKit-Node copied to clipboard
Published 2 years ago • verified publisher icon akamai

Upgrade https-proxy-agent to drop rewrite of `https.request()`

Open zckrs opened this issue 5 years ago • 4 comments

  • https-proxy-agent v2.1.1 to v5.0.0
  • http-proxy-agent removed (not used in code)

You use a old and strange version of https-proxy-agent who rewrite the original function 'https.request()' ...

https://github.com/TooTallNate/node-agent-base/blob/4.3.0/patch-core.js#L13

This rewrite are not neccesary and produce bug when we use a Url object.

Object.assign({}, _options); will transform a Url into Symbol

https://www.diffchecker.com/NGxe92j3

zckrs avatar May 15 '20 14:05 zckrs

ping @AstinCHOI

zckrs avatar May 20 '20 16:05 zckrs

ping @kporowski

zckrs avatar May 22 '20 14:05 zckrs

ping @vreddhi

zckrs avatar May 27 '20 06:05 zckrs

@rajiv @benlancaster @alzix @akalcosmin

Can someone review, merge and release this PR please ?

zckrs avatar Jun 22 '23 10:06 zckrs