django-reverse-unique
django-reverse-unique copied to clipboard
Is this a small error in the README file?
First of all, this project is a great idea. Thanks!
From https://github.com/akaariai/django-reverse-unique/blame/f0dd7c01ae8ed6193a7ee26b7f4e4195ae42dadd/README.rst#L59-L60
current_salary = models.ReverseUnique(
"EmployeeSalary",
filter=Q(valid_from__gte=datetime.now) &
(Q(valid_until__isnull=True) | Q(valid_until__lte=datetime.now))
)
aren't the valid_from and valid_until filters swapped so we can actually an employee's current salary?
current_salary = models.ReverseUnique(
"EmployeeSalary",
filter=Q(valid_from__lte=datetime.now) &
(Q(valid_until__isnull=True) | Q(valid_until__gte=datetime.now))
)