ajaynegi45
Add Accordion
@ajaynegi45 Ready to work on it. Please assign if it’s up for grabs. Thanks!
@ajaynegi45 Ready to work on it. Please assign if it’s up for grabs. Thanks!
Assignee: @sameer1612
Hi @sameer1612 ,
I'm pleased to inform you that I have assigned this issue to you. Your willingness to contribute to our project is greatly appreciated.
Please feel free to start working on the task, and if you have any questions or need assistance during the process, don't hesitate to reach out. We're looking forward to seeing your contributions to the implementation of the accordion feature for Shlok commentaries.
@ajaynegi45 I believe you were referring to these cards with blue headers (clicking on which does nothing as of now). Is the ideal behaviour that, clicking on the card header will hide the content and clicking again will show it?
Please clarify the expectation so that I can start implementing. Thanks!
@ajaynegi45 I believe you were referring to these cards with blue headers (clicking on which does nothing as of now). Is the ideal behaviour that, clicking on the card header will hide the content and clicking again will show it?
Please clarify the expectation so that I can start implementing. Thanks!
Assignee: @sameer1612
Hi @sameer1612 ,
You are absolutely correct in your understanding. The ideal behavior for the accordions is as follows:
- Clicking on the blue header of the accordion should expand and display the commentaries.
- Clicking on the same blue header again should collapse and hide the commentaries.
- Add open and close icon for that
Additionally, please make sure that the accordions are responsive, meaning they should work well on various screen sizes and devices.
At the starting of accordaion and after the chapter and shlok number , include an appropriate title that describes the content. For example, you can use "Commentaries" as the title for accordion.
Thank you for clarifying, and we appreciate your efforts in implementing this feature. If you have any further questions or need additional information, please feel free to ask.
@ajaynegi45 please review and merge the pull request for this issue: https://github.com/ajaynegi45/Library/pull/15
Also, you don't need to write all that css, you installed react bootstrap but did not import the css file for it. We can clean up almost 80% of the css in this project and use ones provided by react bootstrap. If you want me to help with that, do raise a issue and tag me.
I've assigned the issue to you https://github.com/ajaynegi45/Library/issues/24#issue-1929605149